-
Notifications
You must be signed in to change notification settings - Fork 1k
[deploy] update vllm_enable_prefix_caching #6165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deploy] update vllm_enable_prefix_caching #6165
Conversation
Summary of ChangesHello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the handling of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the vllm_enable_prefix_caching parameter to default to None, allowing it to follow vLLM's default behavior. This change enhances flexibility and is consistently applied across the codebase, including engine implementations and documentation. I have one minor suggestion to improve the docstring for better code consistency.
swift/trainers/arguments.py
Outdated
| vllm_limit_mm_per_prompt (Optional[str]): Limit multimedia per prompt. Default is None. | ||
| vllm_max_lora_rank (int): Maximum LoRA rank. Default is 16. | ||
| vllm_enable_prefix_caching (bool): Flag to enable automatic prefix caching. Default is False. | ||
| vllm_enable_prefix_caching (bool): Flag to enable automatic prefix caching. Default is None. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type hint for vllm_enable_prefix_caching in the docstring should be updated to (Optional[bool]) to match the implementation change on line 198, where it is defined as Optional[bool] = None. This will improve consistency between the code and its documentation.
| vllm_enable_prefix_caching (bool): Flag to enable automatic prefix caching. Default is None. | |
| vllm_enable_prefix_caching (Optional[bool]): Flag to enable automatic prefix caching. Default is None. |
No description provided.