Skip to content

Conversation

@Jintao-Huang
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the handling of the vllm_enable_prefix_caching parameter by changing its default value from an explicit False to None. This modification allows the system to align with vLLM's internal default settings for prefix caching, providing greater flexibility and potentially simplifying future updates. The changes include updates to the parameter's type hint in Python code and corresponding adjustments in the documentation to reflect this new default behavior and provide context for previous versions.

Highlights

  • Default Value Change: The default value for the vllm_enable_prefix_caching parameter has been changed from False to None across the codebase. This allows the system to follow vLLM's default behavior for prefix caching.
  • Type Hint Update: The type hint for enable_prefix_caching in relevant Python functions and argument definitions has been updated from bool to Optional[bool] to accommodate the new None default.
  • Documentation Update: Both English and Chinese documentation for command-line parameters have been updated to reflect the new default behavior of vllm_enable_prefix_caching and to clarify its behavior in older ms-swift versions.
  • Engine Argument Handling: The logic for passing enable_prefix_caching to the vLLM engine has been refined, now conditionally adding it to engine_kwargs only when explicitly set (i.e., not None).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the vllm_enable_prefix_caching parameter to default to None, allowing it to follow vLLM's default behavior. This change enhances flexibility and is consistently applied across the codebase, including engine implementations and documentation. I have one minor suggestion to improve the docstring for better code consistency.

vllm_limit_mm_per_prompt (Optional[str]): Limit multimedia per prompt. Default is None.
vllm_max_lora_rank (int): Maximum LoRA rank. Default is 16.
vllm_enable_prefix_caching (bool): Flag to enable automatic prefix caching. Default is False.
vllm_enable_prefix_caching (bool): Flag to enable automatic prefix caching. Default is None.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The type hint for vllm_enable_prefix_caching in the docstring should be updated to (Optional[bool]) to match the implementation change on line 198, where it is defined as Optional[bool] = None. This will improve consistency between the code and its documentation.

Suggested change
vllm_enable_prefix_caching (bool): Flag to enable automatic prefix caching. Default is None.
vllm_enable_prefix_caching (Optional[bool]): Flag to enable automatic prefix caching. Default is None.

@Jintao-Huang Jintao-Huang merged commit 121f8fa into modelscope:main Oct 16, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants