-
Notifications
You must be signed in to change notification settings - Fork 1k
support training for multimodal reranker #6192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support training for multimodal reranker #6192
Conversation
Summary of ChangesHello @0russwest0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the framework's capability to train multimodal reranker models. It introduces new training configurations, refactors model type definitions for better modularity, and implements a specialized preprocessor for multimodal datasets. The changes also include dynamic padding adjustments and robust handling of multimodal inputs, particularly integrating the JinaAI reranker model to ensure its compatibility and optimal performance within the system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for training multimodal reranker models. It introduces new training scripts, a new preprocessor for reranking tasks on the TextCaps dataset, and refactors model type constants to better organize reranker models. It also adds specific support for the jina-reranker-m0 model by patching its forward pass. The changes are mostly well-structured, but I found a critical bug in the data collator for reranker inference that would cause a crash. I've also pointed out a minor improvement for exception handling.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for training multimodal reranker models, which is a significant and well-implemented feature. The changes include new example scripts, a new dataset preprocessor for reranking, refactoring of model types, and support for the jina-reranker-m0 model. The data collators and padding logic have also been updated to accommodate multimodal rerankers. The overall implementation is solid. I have a couple of minor suggestions in the new dataset preprocessor to improve robustness and performance.
| video_grid_thw=None, | ||
| output_attentions=None, | ||
| output_hidden_states=None, | ||
| return_dict=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是不是可用*args, **kwargs更适配一些,增加一个@wraps注解
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不显式声明的话,pre_forward_hook会把position_ids pop掉,开padding_free会有bug
No description provided.