-
Notifications
You must be signed in to change notification settings - Fork 1k
[vllm] support vllm_mm_processor_cache_gb #6210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @hjh0119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the vLLM integration by introducing a new configuration option, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the vllm_mm_processor_cache_gb parameter to configure the multi-modal processor cache size in vLLM. The changes correctly propagate this new parameter through GRPOVllmEngine, VllmEngine, and VllmArguments. The implementation is straightforward and looks good. I have one minor suggestion to improve code formatting for better readability and maintainability.
| for key in [ | ||
| 'enable_expert_parallel', 'enable_sleep_mode', 'disable_cascade_attn', 'load_format', | ||
| 'mm_processor_cache_gb' | ||
| ]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and adherence to Python style guides (PEP 8), it's recommended to format this list of keys with one item per line. This makes the list easier to read and modify in the future.
| for key in [ | |
| 'enable_expert_parallel', 'enable_sleep_mode', 'disable_cascade_attn', 'load_format', | |
| 'mm_processor_cache_gb' | |
| ]: | |
| for key in [ | |
| 'enable_expert_parallel', | |
| 'enable_sleep_mode', | |
| 'disable_cascade_attn', | |
| 'load_format', | |
| 'mm_processor_cache_gb', | |
| ]: |
* vllm_mm_processor_cache_gb * doc
support vllm_mm_processor_cache_gb to set mm processor cache size