Skip to content

Conversation

@hjh0119
Copy link
Collaborator

@hjh0119 hjh0119 commented Oct 20, 2025

support vllm_mm_processor_cache_gb to set mm processor cache size

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hjh0119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the vLLM integration by introducing a new configuration option, vllm_mm_processor_cache_gb. This parameter provides users with explicit control over the cache size allocated for multi-modal processors within vLLM, offering greater flexibility and optimization capabilities for multi-modal inference tasks.

Highlights

  • New Configuration Parameter: Introduced a new configuration parameter, vllm_mm_processor_cache_gb, allowing users to specify the multi-modal processor cache size for vLLM in gigabytes.
  • VLLM Engine Integration: The mm_processor_cache_gb parameter is now accepted and correctly propagated through the GrpoVllmEngine and VllmEngine classes to the underlying vLLM engine initialization.
  • Argument Parsing Update: The VllmArguments class has been updated to include vllm_mm_processor_cache_gb, enabling this new setting to be configured via command-line arguments or configuration files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the vllm_mm_processor_cache_gb parameter to configure the multi-modal processor cache size in vLLM. The changes correctly propagate this new parameter through GRPOVllmEngine, VllmEngine, and VllmArguments. The implementation is straightforward and looks good. I have one minor suggestion to improve code formatting for better readability and maintainability.

Comment on lines +203 to +206
for key in [
'enable_expert_parallel', 'enable_sleep_mode', 'disable_cascade_attn', 'load_format',
'mm_processor_cache_gb'
]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and adherence to Python style guides (PEP 8), it's recommended to format this list of keys with one item per line. This makes the list easier to read and modify in the future.

Suggested change
for key in [
'enable_expert_parallel', 'enable_sleep_mode', 'disable_cascade_attn', 'load_format',
'mm_processor_cache_gb'
]:
for key in [
'enable_expert_parallel',
'enable_sleep_mode',
'disable_cascade_attn',
'load_format',
'mm_processor_cache_gb',
]:

@hjh0119 hjh0119 merged commit e8c54d3 into modelscope:main Oct 20, 2025
1 of 2 checks passed
@hjh0119 hjh0119 deleted the vllm_mm_cache branch October 20, 2025 03:26
Jintao-Huang pushed a commit that referenced this pull request Oct 22, 2025
* vllm_mm_processor_cache_gb

* doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants