[bugfix] fix modelscope patch_hub

[Jintao-Huang]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Jintao-Huang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a targeted bug fix for the modelscope patch_hub functionality. The core change involves clearing the VLLM_USE_MODELSCOPE environment variable before applying Megatron-related patches. This action is crucial for preventing unintended interactions or misconfigurations that might arise from the variable's presence, thereby ensuring the stability and correctness of the patching mechanism.

Highlights

• Environment Variable Management: The VLLM_USE_MODELSCOPE environment variable is now explicitly removed at the beginning of the _patch_megatron function. This ensures that any previous setting of this variable does not interfere with the Megatron patching process, addressing a potential bug related to modelscope patch_hub.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a bug related to ModelScope hub patching by unsetting the VLLM_USE_MODELSCOPE environment variable during Megatron initialization. This is a good change as it prevents potential conflicts with vLLM's model loading mechanism. The fix is correctly placed. I have added one suggestion to include a comment explaining the reason for this change, which will improve code maintainability.

[gemini-code-assist]

For better maintainability, it's good practice to add a comment explaining why this environment variable is being removed. This will provide valuable context for future developers.

Suggested change

	os.environ.pop('VLLM_USE_MODELSCOPE', None)
	# Unset VLLM_USE_MODELSCOPE to prevent vLLM from unconditionally using ModelScope,
	# which can conflict with Megatron's model loading logic.
	os.environ.pop('VLLM_USE_MODELSCOPE', None)