Skip to content

[bugfix] fix modelscope patch_hub #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2025
Merged

[bugfix] fix modelscope patch_hub #6612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions swift/megatron/init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,7 @@ def _apply_rotary_pos_emb_thd(


def _patch_megatron():
os.environ.pop('VLLM_USE_MODELSCOPE', None)
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it's good practice to add a comment explaining why this environment variable is being removed. This will provide valuable context for future developers.

Suggested change
os.environ.pop('VLLM_USE_MODELSCOPE', None)
# Unset VLLM_USE_MODELSCOPE to prevent vLLM from unconditionally using ModelScope,
# which can conflict with Megatron's model loading logic.
os.environ.pop('VLLM_USE_MODELSCOPE', None)

logging_level = logging.root.level
_patch_flash_attn()
_patch_transformer_engine()
Expand Down
Loading