-
Notifications
You must be signed in to change notification settings - Fork 998
fix a bug in test case of template #6654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @addsubmuldiv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug within a specific test case, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a bug within the test_qwen2_5_math_reward test case. The changes involve updating the test's input data by adding another user turn to the conversation, which subsequently adjusts the expected token count in the assertion. A notable correction is the fix for a debug print statement that was previously printing an incorrect variable. These changes are accurate and enhance the correctness of the test.
| template.template_backend = 'jinja' | ||
| res2 = template.encode(inputs) | ||
| template.print_inputs(res) | ||
| template.print_inputs(res2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the test_qwen2_5_math_reward test case where the wrong variable was being printed, and updates the test to include an additional user message in the conversation flow.
- Fixed incorrect variable reference in print statement (was printing
resinstead ofres2) - Added an additional user message to make the test more comprehensive
- Updated expected input_ids length from 364 to 380 to account for the additional message
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This issue has been fixed in this PR. |
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).