[bugfix] fix chatml chat template

[Jintao-Huang]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Jintao-Huang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug within the ChatML chat template implementation. The primary goal is to ensure that the template's suffix is correctly formatted with a newline and that the system accurately identifies and processes stop words by stripping whitespace. These adjustments contribute to more reliable and precise text generation when using the ChatML format.

Highlights

• ChatML Suffix Correction: The default suffix for the ChatML template has been updated to include a newline character, ensuring proper formatting and tokenization.
• Improved Stop Word Handling: The logic for identifying and adding the template's suffix to the list of stop words has been refined to strip any leading or trailing whitespace, preventing issues with generation termination.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a bug in the chatml template by adding a newline to the suffix, which aligns it with expected formatting. The changes also correctly handle suffixes with trailing whitespace when determining stop words and stop tokens. The fix is correct and well-implemented. I have one minor suggestion to improve code readability.

[gemini-code-assist]

This block can be slightly simplified by initializing stop_token_id to None before the if/elif chain. This removes the else block and makes the logic a bit more direct and easier to read.

Suggested change

	if isinstance(suffix_stop, str):
	stop_token_id = tokenizer.convert_tokens_to_ids(suffix_stop)
	elif isinstance(suffix_stop, list) and len(suffix_stop) == 1:
	stop_token_id = suffix_stop[0]
	else:
	stop_token_id = None
	stop_token_id = None
	if isinstance(suffix_stop, str):
	stop_token_id = tokenizer.convert_tokens_to_ids(suffix_stop)
	elif isinstance(suffix_stop, list) and len(suffix_stop) == 1:
	stop_token_id = suffix_stop[0]