Skip to content

Conversation

@Jintao-Huang
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Megatron-SWIFT framework by integrating a new global_aux_loss strategy for MoE router load balancing, which is reflected in updated documentation and argument parsing. Concurrently, it refines the megatron_core dependency constraints and incorporates necessary code adjustments within the Qwen3Next model to maintain compatibility and leverage features from newer megatron.core versions, particularly concerning distributed communication patterns.

Highlights

  • New MoE Load Balancing Strategy: Introduced support for a new global_aux_loss option for Mixture-of-Experts (MoE) router load balancing, updating both documentation and argument definitions.
  • Dependency Version Update: The megatron_core dependency range has been updated to explicitly exclude versions 0.16 and above, ensuring compatibility with current features.
  • Megatron.core API Adaptations: Implemented adaptations within the Qwen3Next model to handle potential API changes in megatron.core versions 0.15.0rc0 and higher, specifically for communication group handling and method signatures.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for global_aux_loss in Megatron and introduces compatibility changes for different versions of megatron-core. The changes are generally well-implemented, but I found a minor issue in the English documentation where a line of Chinese text was added. Please see my specific comment for details.

- moe_router_topk_scaling_factor: Default is None. This parameter is read from config.json.
- moe_router_load_balancing_type: Determines the router’s load balancing strategy. Options are "aux_loss", "seq_aux_loss", "sinkhorn", and "none". Default is None and is read from config.json.
- moe_router_load_balancing_type: Determines the router’s load balancing strategy. Options are "aux_loss", "seq_aux_loss", "global_aux_loss", "sinkhorn", and "none". Default is None and is read from config.json.
- 其中, "global_aux_loss"需要
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line appears to be in Chinese within an English document. It should either be translated to English for consistency or removed if it's not relevant here.

@Jintao-Huang Jintao-Huang merged commit 7809cb8 into modelscope:main Nov 21, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants