Skip to content

[bugfix] fix qwen3_omni position_ids dtype#7194

Merged
Jintao-Huang merged 1 commit intomodelscope:mainfrom
Jintao-Huang:fix_qwen3_omni_position_ids_dtype
Dec 24, 2025
Merged

[bugfix] fix qwen3_omni position_ids dtype#7194
Jintao-Huang merged 1 commit intomodelscope:mainfrom
Jintao-Huang:fix_qwen3_omni_position_ids_dtype

Conversation

@Jintao-Huang
Copy link
Collaborator

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the Qwen3-Omni model's position_ids generation. The change ensures that the position_ids are always of an integer data type (torch.int64), which is critical for their correct interpretation and use within the model. This fix prevents potential runtime errors or incorrect behavior that could arise from position_ids being inadvertently represented as floating-point numbers.

Highlights

  • Bugfix: Qwen3-Omni position_ids dtype: Corrected a potential issue where position_ids for the Qwen3-Omni model might be a floating-point type by explicitly converting them to torch.int64 if they are detected as floating-point.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug where position_ids might have an incorrect floating-point data type, leading to potential issues. The change correctly converts position_ids to torch.int64 if it is detected as a floating-point tensor, ensuring the correct data type for subsequent operations. This is a straightforward and necessary fix.

@Jintao-Huang Jintao-Huang merged commit 9074ab0 into modelscope:main Dec 24, 2025
1 of 3 checks passed
meichangsu1 pushed a commit to tpx818/ms-swift that referenced this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants