[misc] add megatron trainer state to align with transformer trainer#7199
[misc] add megatron trainer state to align with transformer trainer#7199hjh0119 merged 1 commit intomodelscope:mainfrom
Conversation
Summary of ChangesHello @hjh0119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Megatron GRPO trainer by introducing a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a MegatronTrainerState class to provide a transformers.TrainerState-like interface for reward functions in Megatron GRPO training. This is a good change that improves compatibility and makes it easier for reward functions to access training progress like global_step and max_steps. The implementation is clean and well-integrated into the trainer and utility files, and the documentation has been updated accordingly. I have one minor suggestion to improve code readability.
| def get_trainer_state(self): | ||
| args = get_args() | ||
| self.state.update( | ||
| global_step=getattr(args, 'curr_iteration', 0) or 0, max_steps=getattr(args, 'train_iters', 0) or 0) |
There was a problem hiding this comment.
The expression getattr(args, 'curr_iteration', 0) or 0 is functionally correct, but can be slightly confusing. A more idiomatic and readable pattern to achieve the same result (get an attribute, defaulting to 0 if it's missing or None) is getattr(args, 'curr_iteration', None) or 0. This makes the intent clearer: first attempt to get the attribute (defaulting to None if absent), then coalesce a None result to 0.
| global_step=getattr(args, 'curr_iteration', 0) or 0, max_steps=getattr(args, 'train_iters', 0) or 0) | |
| global_step=getattr(args, 'curr_iteration', None) or 0, max_steps=getattr(args, 'train_iters', None) or 0) |
No description provided.