[misc] support structured_outputs_regex#7215
Conversation
Summary of ChangesHello @hjh0119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the system by adding support for structured outputs through guided decoding, specifically for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for structured_outputs_regex to enable guided decoding with the vLLM backend. The changes are well-integrated, covering documentation, argument parsing, and the inference engine logic. The implementation correctly handles different vLLM versions by checking for StructuredOutputsParams and falling back to GuidedDecodingParams. My main feedback is a suggestion to simplify a condition check in the vLLM engine for better readability and maintainability.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request effectively integrates support for structured_outputs_regex to enable guided decoding with vLLM. The changes are well-propagated through argument parsing, configuration objects, and the inference engine. The implementation also correctly handles backward compatibility with older vLLM versions. I've identified one issue where the new argument is missing from the Megatron-specific argument classes, which would prevent the feature from working in that context. A code suggestion is provided to fix this.
| top_k: int = 50 | ||
| top_p: float = 0.9 | ||
| repetition_penalty: float = 1. | ||
|
|
There was a problem hiding this comment.
To enable structured_outputs_regex for the Megatron GRPO trainer, it needs to be added as an argument here in RLHFMegatronArgumentsMixin. Without this, getattr(args, 'structured_outputs_regex', None) in swift/megatron/trainers/grpo_trainer.py will always return None, preventing the feature from being used in this configuration.
| structured_outputs_regex: Optional[str] = None |
No description provided.