[docs] update docs & update dataset 'loss'#7402
[docs] update docs & update dataset 'loss'#7402Jintao-Huang merged 3 commits intomodelscope:mainfrom
Conversation
Summary of ChangesHello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a type inconsistency bug in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix an issue where the length field for reranker tasks could be either an integer or a list, causing inconsistencies. While the change in swift/template/base.py correctly addresses this for reranker tasks, it introduces a critical bug for other tasks like causal_lm when Megatron is used, as it would cause a TypeError. I have provided a more targeted fix for this issue. Additionally, I've pointed out a minor typo and a formatting issue in the documentation files.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This PR updates the documentation for Swift 4.0.0 and refactors the loss scale calculation logic. The documentation changes are clear and helpful. The code change in swift/loss_scale/base.py simplifies how the loss value from datasets is handled. However, the conditional logic is a bit complex, and its readability could be improved. I have one suggestion to enhance readability.
No description provided.