Skip to content

[docs] update docs & update dataset 'loss'#7402

Merged
Jintao-Huang merged 3 commits intomodelscope:mainfrom
Jintao-Huang:fix_reranker_length
Jan 15, 2026
Merged

[docs] update docs & update dataset 'loss'#7402
Jintao-Huang merged 3 commits intomodelscope:mainfrom
Jintao-Huang:fix_reranker_length

Conversation

@Jintao-Huang
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a type inconsistency bug in the encode method within swift/template/base.py, ensuring that the length attribute is always returned as a list, regardless of whether it contains a single element or multiple. Additionally, it updates the documentation for supported models and datasets in both Chinese and English, adding a warning to guide users to the correct version-specific documentation.

Highlights

  • Type Consistency Fix: Corrected an issue in swift/template/base.py where the length field in the encoded dictionary could be either an integer or a list of integers, ensuring it is now consistently a list.
  • Documentation Update: Added a warning to both Chinese and English versions of the "Supported Models and Datasets" documentation, clarifying that the document is for swift 4.0.0 and providing a link to the v3.12 documentation for older versions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue where the length field for reranker tasks could be either an integer or a list, causing inconsistencies. While the change in swift/template/base.py correctly addresses this for reranker tasks, it introduces a critical bug for other tasks like causal_lm when Megatron is used, as it would cause a TypeError. I have provided a more targeted fix for this issue. Additionally, I've pointed out a minor typo and a formatting issue in the documentation files.

@Jintao-Huang Jintao-Huang changed the title [bugfix] fix reranker length is int/list[int] [docs] update docs Jan 15, 2026
@Jintao-Huang Jintao-Huang changed the title [docs] update docs [docs] update docs & update dataset 'loss' Jan 15, 2026
@Jintao-Huang
Copy link
Collaborator Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates the documentation for Swift 4.0.0 and refactors the loss scale calculation logic. The documentation changes are clear and helpful. The code change in swift/loss_scale/base.py simplifies how the loss value from datasets is handled. However, the conditional logic is a bit complex, and its readability could be improved. I have one suggestion to enhance readability.

@Jintao-Huang Jintao-Huang merged commit b59964f into modelscope:main Jan 15, 2026
2 of 3 checks passed
meichangsu1 pushed a commit to tpx818/ms-swift that referenced this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants