[readme] update error timeline of news#7404
Conversation
Summary of ChangesHello @shizhengLi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a precise documentation correction, ensuring the accuracy of the project's news timeline. It updates the anticipated release year for the 'ms-swift v4.0' major version across the primary README files, providing correct information to users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
thanks! |
There was a problem hiding this comment.
Code Review
This pull request corrects a date in the 'News' section of both the English and Chinese README files. While the change itself seems correct and fixes a local ordering issue, I've identified a potential systemic issue with other dates in the same section. Many news items dated for 2025 are described in a way that suggests they have already occurred, indicating that '2025' might be a typo for '2024' in multiple places. I've added comments to both files recommending a review of all '2025' dates for consistency and accuracy.
|
|
||
| ## 🎉 News | ||
| - 🎁 2025.01.15: **ms-swift v4.0** major version update is in progress. It is recommended to use the stable branch [release/3.12](https://github.com/modelscope/ms-swift/tree/release/3.12). You can provide your feedback in [this issue](https://github.com/modelscope/ms-swift/issues/7250). Thank you for your support. | ||
| - 🎁 2026.01.15: **ms-swift v4.0** major version update is in progress. It is recommended to use the stable branch [release/3.12](https://github.com/modelscope/ms-swift/tree/release/3.12). You can provide your feedback in [this issue](https://github.com/modelscope/ms-swift/issues/7250). Thank you for your support. |
There was a problem hiding this comment.
Thanks for correcting the date for the v4.0 update. This also fixes the chronological order with the next item.
However, looking at the surrounding news items, there seems to be a broader issue. Many items dated for 2025 (e.g., on lines 81, 82, 84, etc.) are phrased as if they have already happened (e.g., "is now available", "Added support for"). This suggests that 2025 might be a typo for 2024 across this entire section.
It would be great if you could take this opportunity to review all 2025 dates in the news list for consistency. If they are typos, they should be corrected to 2024 and the list re-sorted to maintain reverse chronological order.
|
|
||
| ## 🎉 新闻 | ||
| - 🎁 2025.01.15: **ms-swift v4.0**大版本更新进行中,建议使用稳定分支[release/3.12](https://github.com/modelscope/ms-swift/tree/release/3.12),您的建议可以在[这个issue](https://github.com/modelscope/ms-swift/issues/7250)中反馈给我们,感谢您的支持。 | ||
| - 🎁 2026.01.15: **ms-swift v4.0**大版本更新进行中,建议使用稳定分支[release/3.12](https://github.com/modelscope/ms-swift/tree/release/3.12),您的建议可以在[这个issue](https://github.com/modelscope/ms-swift/issues/7250)中反馈给我们,感谢您的支持。 |
There was a problem hiding this comment.
Thanks for correcting the date for the v4.0 update. Similar to README.md, there seems to be a broader issue with dates in this news section. Many items dated for 2025 (e.g., on lines 77, 78, 80, etc.) are phrased as if they have already happened (e.g., "现已支持!" which means "now available!"). This suggests that 2025 might be a typo for 2024 across this entire section.
It would be great if you could take this opportunity to review all 2025 dates in this file as well for consistency and correctness.
PR type
PR information
There is a time error of the new. It's should be 2026, not 2025
Experiment results
Paste your experiment result here(if needed).