Skip to content

[readme] update error timeline of news#7404

Merged
Jintao-Huang merged 1 commit intomodelscope:mainfrom
shizhengLi:main
Jan 15, 2026
Merged

[readme] update error timeline of news#7404
Jintao-Huang merged 1 commit intomodelscope:mainfrom
shizhengLi:main

Conversation

@shizhengLi
Copy link
Contributor

PR type

  • Bug Fix
  • New Feature
  • [✅] Document Updates
  • More Models or Datasets Support

PR information

There is a time error of the new. It's should be 2026, not 2025

Experiment results

Paste your experiment result here(if needed).

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shizhengLi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a precise documentation correction, ensuring the accuracy of the project's news timeline. It updates the anticipated release year for the 'ms-swift v4.0' major version across the primary README files, providing correct information to users.

Highlights

  • Documentation Update: Corrected a timeline error in the news section of both the English and Chinese README files, specifically updating the year for the 'ms-swift v4.0' major version update from 2025 to 2026.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Jintao-Huang
Copy link
Collaborator

thanks!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a date in the 'News' section of both the English and Chinese README files. While the change itself seems correct and fixes a local ordering issue, I've identified a potential systemic issue with other dates in the same section. Many news items dated for 2025 are described in a way that suggests they have already occurred, indicating that '2025' might be a typo for '2024' in multiple places. I've added comments to both files recommending a review of all '2025' dates for consistency and accuracy.


## 🎉 News
- 🎁 2025.01.15: **ms-swift v4.0** major version update is in progress. It is recommended to use the stable branch [release/3.12](https://github.com/modelscope/ms-swift/tree/release/3.12). You can provide your feedback in [this issue](https://github.com/modelscope/ms-swift/issues/7250). Thank you for your support.
- 🎁 2026.01.15: **ms-swift v4.0** major version update is in progress. It is recommended to use the stable branch [release/3.12](https://github.com/modelscope/ms-swift/tree/release/3.12). You can provide your feedback in [this issue](https://github.com/modelscope/ms-swift/issues/7250). Thank you for your support.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for correcting the date for the v4.0 update. This also fixes the chronological order with the next item.

However, looking at the surrounding news items, there seems to be a broader issue. Many items dated for 2025 (e.g., on lines 81, 82, 84, etc.) are phrased as if they have already happened (e.g., "is now available", "Added support for"). This suggests that 2025 might be a typo for 2024 across this entire section.

It would be great if you could take this opportunity to review all 2025 dates in the news list for consistency. If they are typos, they should be corrected to 2024 and the list re-sorted to maintain reverse chronological order.


## 🎉 新闻
- 🎁 2025.01.15: **ms-swift v4.0**大版本更新进行中,建议使用稳定分支[release/3.12](https://github.com/modelscope/ms-swift/tree/release/3.12),您的建议可以在[这个issue](https://github.com/modelscope/ms-swift/issues/7250)中反馈给我们,感谢您的支持。
- 🎁 2026.01.15: **ms-swift v4.0**大版本更新进行中,建议使用稳定分支[release/3.12](https://github.com/modelscope/ms-swift/tree/release/3.12),您的建议可以在[这个issue](https://github.com/modelscope/ms-swift/issues/7250)中反馈给我们,感谢您的支持。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for correcting the date for the v4.0 update. Similar to README.md, there seems to be a broader issue with dates in this news section. Many items dated for 2025 (e.g., on lines 77, 78, 80, etc.) are phrased as if they have already happened (e.g., "现已支持!" which means "now available!"). This suggests that 2025 might be a typo for 2024 across this entire section.

It would be great if you could take this opportunity to review all 2025 dates in this file as well for consistency and correctness.

@Jintao-Huang Jintao-Huang merged commit 4d23b6e into modelscope:main Jan 15, 2026
1 check passed
meichangsu1 pushed a commit to tpx818/ms-swift that referenced this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants