[megatron] support megatron embedding#7862
Conversation
Summary of ChangesHello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly extends the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces Megatron support for embedding models, along with necessary updates to documentation, arguments, and trainer logic. The changes include adding embedding as a supported task type, implementing specific handling for embedding models in Megatron's GPT bridge and model, and creating a dedicated MegatronEmbeddingTrainer. Several documentation files have been updated to reflect these new capabilities. The refactoring of RerankerLoss to PointwiseRerankerLoss and the corresponding updates in loss/mapping.py are also noted. Overall, the changes are well-aligned with the goal of supporting Megatron embedding.
| if 'num_samples' in res: | ||
| num_samples = res.pop('num_samples') |
There was a problem hiding this comment.
The num_samples key is popped from res and then potentially re-added for Megatron. While this might be intended, ensure that num_samples is consistently handled across different scenarios (Megatron vs. non-Megatron, and various task types) to prevent unexpected behavior or incorrect batching/loss calculations.
squash from #7630