[docs]Upgrade MindSpeed to stable maintenance version.#7943
[docs]Upgrade MindSpeed to stable maintenance version.#7943Jintao-Huang merged 1 commit intomodelscope:mainfrom
Conversation
Summary of ChangesHello @Ginray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the installation instructions within the NPU support documentation to reference a more stable and recent version of the MindSpeed library. By upgrading to version Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to use a stable maintenance version of MindSpeed, replacing a specific commit hash with a version tag. This is a good change for maintainability and clarity. I've added a couple of suggestions to further improve the installation instructions by using a shallow git clone, which will be more efficient for users following the guide.
| git clone https://gitcode.com/Ascend/MindSpeed.git | ||
| cd MindSpeed | ||
| git checkout 0016137f0dcfeab3308e0d16994046740c0e4ad9 | ||
| git checkout 2.3.0_core_r0.12.1 |
There was a problem hiding this comment.
For a more efficient installation, consider using git clone --depth 1 --branch <tag> to perform a shallow clone of the specific tag. This avoids downloading the full repository history, which is faster and saves disk space.
| git clone https://gitcode.com/Ascend/MindSpeed.git | |
| cd MindSpeed | |
| git checkout 0016137f0dcfeab3308e0d16994046740c0e4ad9 | |
| git checkout 2.3.0_core_r0.12.1 | |
| git clone --depth 1 --branch 2.3.0_core_r0.12.1 https://gitcode.com/Ascend/MindSpeed.git | |
| cd MindSpeed |
| git clone https://gitcode.com/Ascend/MindSpeed.git | ||
| cd MindSpeed | ||
| git checkout 0016137f0dcfeab3308e0d16994046740c0e4ad9 | ||
| git checkout 2.3.0_core_r0.12.1 |
There was a problem hiding this comment.
For a more efficient installation, consider using git clone --depth 1 --branch <tag> to perform a shallow clone of the specific tag. This avoids downloading the full repository history, which is faster and saves disk space.
| git clone https://gitcode.com/Ascend/MindSpeed.git | |
| cd MindSpeed | |
| git checkout 0016137f0dcfeab3308e0d16994046740c0e4ad9 | |
| git checkout 2.3.0_core_r0.12.1 | |
| git clone --depth 1 --branch 2.3.0_core_r0.12.1 https://gitcode.com/Ascend/MindSpeed.git | |
| cd MindSpeed |
PR type
PR information
Upgrade MindSpeed to stable maintenance version.
Avoid known bugs, for example, an error will occur when setting moe_permute_fusion to true: AttributeError: 'NoneType' object has no attribute 'tolist'.
Experiment results
Paste your experiment result here(if needed).