Skip to content

[docs]Upgrade MindSpeed to stable maintenance version.#7943

Merged
Jintao-Huang merged 1 commit intomodelscope:mainfrom
Ginray:main
Jan 30, 2026
Merged

[docs]Upgrade MindSpeed to stable maintenance version.#7943
Jintao-Huang merged 1 commit intomodelscope:mainfrom
Ginray:main

Conversation

@Ginray
Copy link
Contributor

@Ginray Ginray commented Jan 30, 2026

PR type

  • Bug Fix
  • New Feature
  • [ √ ] Document Updates
  • More Models or Datasets Support

PR information

Upgrade MindSpeed to stable maintenance version.
Avoid known bugs, for example, an error will occur when setting moe_permute_fusion to true: AttributeError: 'NoneType' object has no attribute 'tolist'.

Experiment results

Paste your experiment result here(if needed).

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Ginray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the installation instructions within the NPU support documentation to reference a more stable and recent version of the MindSpeed library. By upgrading to version 2.3.0_core_r0.12.1, users will benefit from a more robust environment, avoiding critical errors and known bugs that were present in previous iterations. This ensures that the provided best practices guide users towards a reliable setup.

Highlights

  • Documentation Update: The documentation for NPU support has been updated to reflect a new, stable maintenance version of the MindSpeed library.
  • Bug Fixes: This upgrade aims to avoid known bugs, specifically mentioning an AttributeError: 'NoneType' object has no attribute 'tolist' that occurs when moe_permute_fusion is set to true.
  • Version Pinning: The git checkout command in the installation instructions has been changed from a specific commit hash (0016137f0dcfeab3308e0d16994046740c0e4ad9) to a stable version tag (2.3.0_core_r0.12.1).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to use a stable maintenance version of MindSpeed, replacing a specific commit hash with a version tag. This is a good change for maintainability and clarity. I've added a couple of suggestions to further improve the installation instructions by using a shallow git clone, which will be more efficient for users following the guide.

Comment on lines 75 to +77
git clone https://gitcode.com/Ascend/MindSpeed.git
cd MindSpeed
git checkout 0016137f0dcfeab3308e0d16994046740c0e4ad9
git checkout 2.3.0_core_r0.12.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For a more efficient installation, consider using git clone --depth 1 --branch <tag> to perform a shallow clone of the specific tag. This avoids downloading the full repository history, which is faster and saves disk space.

Suggested change
git clone https://gitcode.com/Ascend/MindSpeed.git
cd MindSpeed
git checkout 0016137f0dcfeab3308e0d16994046740c0e4ad9
git checkout 2.3.0_core_r0.12.1
git clone --depth 1 --branch 2.3.0_core_r0.12.1 https://gitcode.com/Ascend/MindSpeed.git
cd MindSpeed

Comment on lines 73 to +75
git clone https://gitcode.com/Ascend/MindSpeed.git
cd MindSpeed
git checkout 0016137f0dcfeab3308e0d16994046740c0e4ad9
git checkout 2.3.0_core_r0.12.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For a more efficient installation, consider using git clone --depth 1 --branch <tag> to perform a shallow clone of the specific tag. This avoids downloading the full repository history, which is faster and saves disk space.

Suggested change
git clone https://gitcode.com/Ascend/MindSpeed.git
cd MindSpeed
git checkout 0016137f0dcfeab3308e0d16994046740c0e4ad9
git checkout 2.3.0_core_r0.12.1
git clone --depth 1 --branch 2.3.0_core_r0.12.1 https://gitcode.com/Ascend/MindSpeed.git
cd MindSpeed

@Jintao-Huang Jintao-Huang merged commit 857dc2e into modelscope:main Jan 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants