Conversation
support paddleOCR-vl-1.5
support glm_ocr
fix glm-ocr template
update faq
update faq
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the clarity and accuracy of the project's Frequently Asked Questions documentation. By updating existing entries, removing outdated information, and providing more direct references to examples, the changes aim to improve the user experience and reduce potential confusion for users interacting with Swift 3.0+ features, particularly regarding parameter usage, model fine-tuning, and deployment configurations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the FAQ documents in both Chinese and English. The changes include clarifying version applicability, updating answers for newly supported features, removing an outdated question, and improving the phrasing of questions and answers in the English version. I've found a couple of minor issues in the English FAQ file: a typo in a code snippet and a link pointing to a less specific documentation page. I've provided suggestions to fix them. Overall, these are good improvements to the documentation.
| ### Q72: Does swift3.0 not support get_default_template_type? | ||
| Please check `model.model_meta.template`, the information is available in `model.model_meta` and `model.model_info`. | ||
| ### Q72: Is get_default_template_type no longer supported in SWIFT versions 3.0 and later? | ||
| Please check `model.model_meta.templat`e. The information is stored in `model.model_meta` and `model.model_info`. |
There was a problem hiding this comment.
There's a typo in the code snippet. model.model_meta.template should be model.model_meta.template.
| Please check `model.model_meta.templat`e. The information is stored in `model.model_meta` and `model.model_info`. | |
| Please check `model.model_meta.template`. The information is stored in `model.model_meta` and `model.model_info`. |
| ``` | ||
| Saving checkpoints per epoch is not yet supported. | ||
| ### Q161: With the script below, can megatron-swift save checkpoints per epoch? | ||
| Yes, please refer to the command-line parameter [save_strategy](https://swift.readthedocs.io/en/latest/Instruction/Command-line-parameters.html). |
There was a problem hiding this comment.
The link for save_strategy points to the general command-line parameters documentation. Since the question is about megatron-swift, it would be more helpful to link directly to the Megatron-SWIFT command-line parameters documentation where save_strategy is described.
| Yes, please refer to the command-line parameter [save_strategy](https://swift.readthedocs.io/en/latest/Instruction/Command-line-parameters.html). | |
| Yes, please refer to the command-line parameter [save_strategy](https://swift.readthedocs.io/en/latest/Megatron-SWIFT/Command-line-parameters.html). |
|
/gemini review |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
/gemini review |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).