Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating documentation and example scripts to reflect the latest capabilities and best practices of the ms-swift framework. The changes ensure that users have accurate information regarding supported models, dependency versions, and command-line arguments for training and deployment, enhancing clarity and usability for both English and Chinese speaking audiences. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request primarily updates documentation across multiple files, including READMEs and quick start guides, to reflect new model support and updated examples. While most changes are straightforward content updates, I've identified several inconsistencies in model names and supported model counts across different documentation files. These should be synchronized to prevent user confusion. I've added specific comments with suggestions on the affected files. Other changes, like pinning dependency versions, are good improvements.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request primarily updates documentation across several files (README.md, README_CN.md, and others in docs/) to reflect the latest supported models, dependency versions, and improved examples. The changes are consistent and enhance the clarity of the documentation. I've found one minor issue in an example script where an argument is duplicated, which I've commented on.
examples/models/qwen3_omni/zero3.sh
Outdated
| --lora_rank 8 \ | ||
| --lora_alpha 32 \ | ||
| --target_modules all-linear \ | ||
| --experts_impl grouped_mm \ |
No description provided.