[bugfix] fix minimax 2.1 enable_tp

[Jintao-Huang]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the Minimax M2 model's implementation within the Megatron framework. The fix ensures that the model correctly identifies when tensor parallelism is active, which is crucial for proper distributed training and inference. By rectifying the method used to check for tensor parallelism, the change prevents potential misconfigurations or performance issues related to distributed operations.

Highlights

• Bug Fix: Corrected the method used to determine if tensor parallelism is enabled within the get_query_key_value_tensors function.
• Tensor Parallelism: Switched from checking expert_data_parallel_world_size to tensor_model_parallel_world_size to accurately reflect the tensor parallelism state.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• swift/megatron/model/gpts/minimax_m2.py
  • Updated the enable_tp check from mpu.get_expert_data_parallel_world_size() to mpu.get_tensor_model_parallel_world_size().

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request correctly addresses a bug where the enable_tp flag was incorrectly determined using get_expert_data_parallel_world_size() instead of get_tensor_model_parallel_world_size(). This change ensures that the tensor parallelism flag accurately reflects the tensor model parallel world size, which is crucial for correct distributed training configurations.