Skip to content

[bugfix] fix megatron kimi_k2#8238

Merged
Jintao-Huang merged 1 commit intomodelscope:mainfrom
Jintao-Huang:fix_kimi_k2_2
Mar 8, 2026
Merged

[bugfix] fix megatron kimi_k2#8238
Jintao-Huang merged 1 commit intomodelscope:mainfrom
Jintao-Huang:fix_kimi_k2_2

Conversation

@Jintao-Huang
Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a crucial bug fix by ensuring that the 'kimi_k2' model type is correctly identified and handled within the Megatron framework's model configuration. This change is essential for supporting and integrating models of the 'kimi_k2' type, allowing them to be processed without errors.

Highlights

  • Bugfix: Kimi_k2 Model Recognition: Resolved an issue where the 'kimi_k2' model type was not properly recognized within the Megatron model configuration, preventing its correct processing.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • swift/megatron/model/model_config.py
    • Added 'kimi_k2' to the set of recognized Hugging Face model types in the convert_hf_config function.
Activity
  • No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds 'kimi_k2' to a set of model types to apply specific configurations, which appears to be a bugfix. The change is functionally correct. I've provided one suggestion to improve code readability by sorting the elements within the set.

Comment on lines 417 to 422
'deepseek',
'deepseek_v2',
'deepseek_v3',
'kimi_k2',
'deepseek_v32',
'dots1',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and maintainability, it would be beneficial to keep the items in this set sorted alphabetically.

Suggested change
'deepseek',
'deepseek_v2',
'deepseek_v3',
'kimi_k2',
'deepseek_v32',
'dots1',
'deepseek',
'deepseek_v2',
'deepseek_v3',
'deepseek_v32',
'dots1',
'kimi_k2',

@Jintao-Huang
Copy link
Copy Markdown
Collaborator Author

截屏2026-03-08 15 48 48

@Jintao-Huang Jintao-Huang merged commit 67d8a2e into modelscope:main Mar 8, 2026
2 of 3 checks passed
Jintao-Huang added a commit that referenced this pull request Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant