[bugfix] fix wandb log

[hjh0119]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug related to Weights & Biases (W&B) logging by adjusting how profiling metrics are committed. The change ensures that these metrics are staged rather than immediately finalized, which is crucial for maintaining data integrity and proper grouping of logged information within a single training step.

Highlights

• W&B Logging Fix: Modified the wandb.log call within the profiling_context function to explicitly set commit=False. This ensures that profiling metrics are logged without immediately committing them, allowing for better aggregation with other metrics in the same step.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds commit=False to wandb.log to prevent creating extra steps for profiling metrics. I've also pointed out a similar issue with swanlab.log that should be addressed for consistent logging behavior.

[gemini-code-assist]

To ensure consistent logging behavior, commit=False should also be applied to swanlab.log on line 599. Similar to wandb, swanlab.log without commit=False can create unintended extra steps. It would be best to apply this change as well:

    if 'swanlab' in trainer.args.report_to and swanlab.get_run() is not None and is_main_process:
        swanlab.log(profiling_metrics, commit=False)