update swift image 4.1#9153
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the recommended versions for several core dependencies, including Python, CUDA, Transformers, and vLLM, across the project's README and documentation files. It also adds and updates Docker image tags to support SWIFT 4.1.2. The review feedback identifies inconsistencies where the new recommended Transformers version (5.5.4) conflicts with existing constraints in the installation scripts and was missed in certain documentation tables.
| | cuda | | cuda12.8/12.9 | No need to install if using CPU, NPU, MPS | | ||
| | torch | >=2.0 | 2.8.0/2.10.0 | | | ||
| | transformers | >=4.33 | 4.57.6/5.2.0 | | | ||
| | transformers | >=4.33 | 4.57.6/5.5.4 | | |
There was a problem hiding this comment.
The recommended version for transformers has been updated to 5.5.4. However, requirements/install_all.sh (line 6) still contains a version constraint of transformers<5.4.0. This inconsistency will prevent users from installing the recommended version when using the installation script. Please update the constraint in requirements/install_all.sh to accommodate the new recommended version.
| | transformer-engine | >=2.3 | 2.13.0 | | | ||
| | apex | | 0.1 | | | ||
| | megatron-core | >=0.12,<0.17 | 0.16 | | | ||
| | megatron-core | >=0.12,<0.17 | 0.16.1 | | |
There was a problem hiding this comment.
The recommended transformers version in the table below (line 78, context) is still set to 4.57.6/5.2.0. Please update it to 4.57.6/5.5.4 to maintain consistency with the updates made in README.md and other documentation files.
| | transformer-engine | >=2.3 | 2.13.0 | | | ||
| | apex | | 0.1 | | | ||
| | megatron-core | >=0.12,<0.17 | 0.16 | | | ||
| | megatron-core | >=0.12,<0.17 | 0.16.1 | | |
There was a problem hiding this comment.
The recommended transformers version in the table below (line 78, context) is still set to 4.57.6/5.2.0. Please update it to 4.57.6/5.5.4 to maintain consistency with the updates made in README.md and other documentation files.
2 participants
No description provided.