Skip to content

[model] update minicpmo 4_5#9159

Merged
Jintao-Huang merged 2 commits into
modelscope:mainfrom
Jintao-Huang:update_minicpmo4_5
Apr 20, 2026
Merged

[model] update minicpmo 4_5#9159
Jintao-Huang merged 2 commits into
modelscope:mainfrom
Jintao-Huang:update_minicpmo4_5

Conversation

@Jintao-Huang
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates documentation links and command-line parameter descriptions for the minicpmo model, notably changing the default value of INIT_AUDIO to True. In the code, _get_vision_embedding was updated to handle empty inputs and tensor type checks more robustly. Additionally, the template logic for minicpm was adjusted to handle video tags based on audio usage settings. A review comment suggests adding parentheses to a logical expression in swift/template/templates/minicpm.py to clarify operator precedence and improve readability.

Comment thread swift/template/templates/minicpm.py
@Jintao-Huang Jintao-Huang merged commit d865c26 into modelscope:main Apr 20, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant