[bugfix] fix qwen3_5 sp compat transformers 5.5.4#9165
Merged
Jintao-Huang merged 2 commits intoApr 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic signature inspection for Qwen model patching to conditionally pass the cache_position argument. The review feedback suggests restoring the try-except block for sequence_parallel_context imports to maintain environment compatibility and recommends extending the signature check to other parameters like cache_params and attention_mask for better robustness across different versions of the transformers library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.