[bugfix] fix optimizer deepspeed#9173
Merged
Jintao-Huang merged 4 commits intoApr 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the optimizer and scheduler creation process by introducing an optimizer_callback and delegating tasks to HfTrainer static methods. It also adds a mechanism to filter out empty parameter groups during optimizer initialization. The review feedback points out that the create_optimizer_and_scheduler method should call the local create_optimizer to ensure the parameter group filtering is applied and suggests adding a null check for the optimizer for increased robustness.
hjh0119
approved these changes
Apr 22, 2026
Jintao-Huang
added a commit
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.