Skip to content

[bugfix] fix agent_template test#9215

Merged
Jintao-Huang merged 3 commits into
mainfrom
fix_agent_template_ci
Apr 26, 2026
Merged

[bugfix] fix agent_template test#9215
Jintao-Huang merged 3 commits into
mainfrom
fix_agent_template_ci

Conversation

@Jintao-Huang
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the way agent templates are assigned within the framework, moving from direct object assignment to setting a string identifier on the _agent_template attribute. These changes are applied across various example scripts and test files. A review comment points out that a test case was disabled in the __main__ block of tests/test_align/test_template/test_agent.py, which may have been a temporary change for local debugging that should be reverted to maintain full test coverage.

Comment on lines +629 to +630
# test_qwen3_5()
test_deepseek_v3_1()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In the __main__ block, test_qwen3_5() has been commented out while test_deepseek_v3_1() was enabled. If this change was only intended for local debugging, please revert it or enable both tests to maintain full coverage when running the script directly.

@Jintao-Huang Jintao-Huang merged commit 890d782 into main Apr 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant