[docs] update docs#9250
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the dependency constraints for 'transformers' and 'trl' across documentation and configuration files, and adds a hyperlink to the Mcore-Bridge documentation. The review feedback suggests ensuring consistency in the documentation tables by including the recommended version for 'trl' and improving the dependency specification in the installation script to match the constraints defined in 'requirements/framework.txt'.
| | modelscope | >=1.23 | | | | ||
| | peft | >=0.11,<0.20 | | LoRA | | ||
| | trl | >=0.15,<0.30 | | RLHF | | ||
| | trl | >=0.15,<1.0 | | RLHF | |
There was a problem hiding this comment.
For consistency with other documentation files (such as README.md and SWIFT-installation.md), the recommended version for trl should be specified as 0.29.1 in this table.
| | trl | >=0.15,<1.0 | | RLHF | | |
| | trl | >=0.15,<1.0 | 0.29.1 | RLHF | |
| | modelscope | >=1.23 | | | | ||
| | peft | >=0.11,<0.20 | | LoRA | | ||
| | trl | >=0.15,<0.30 | | RLHF | | ||
| | trl | >=0.15,<1.0 | | RLHF | |
There was a problem hiding this comment.
For consistency with other documentation files, the recommended version for trl should be specified as 0.29.1 in this table.
| | trl | >=0.15,<1.0 | | RLHF | | |
| | trl | >=0.15,<1.0 | 0.29.1 | RLHF | |
| pip install "vllm>=0.5.1" -U | ||
| pip install "lmdeploy>=0.5,<0.10.2" -U --no-deps | ||
| pip install "transformers<5.7" "trl<0.30" peft -U | ||
| pip install "transformers<5.8" "trl<1.0" peft -U |
There was a problem hiding this comment.
The dependency constraints in this script should be consistent with those defined in requirements/framework.txt. This includes adding the lower bounds for transformers and trl, adding the version constraint for peft, and using the same version string format (e.g., <5.8.0 instead of <5.8).
| pip install "transformers<5.8" "trl<1.0" peft -U | |
| pip install "transformers>=4.33,<5.8.0" "trl>=0.15,<1.0" "peft>=0.11,<0.20" -U |
2 participants
No description provided.