Skip to content

update requirements#9275

Merged
Jintao-Huang merged 1 commit into
modelscope:mainfrom
Jintao-Huang:update_requirements_0507
May 6, 2026
Merged

update requirements#9275
Jintao-Huang merged 1 commit into
modelscope:mainfrom
Jintao-Huang:update_requirements_0507

Conversation

@Jintao-Huang
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates documentation regarding mcore-bridge version requirements, extends the supported transformers version range in the framework requirements, and removes runtime version checks for mcore-bridge in the code. Feedback indicates that removing these version checks reduces the helpfulness of error reporting for users with older library versions and introduces inconsistency, suggesting that the checks should be retained with updated version strings.

I am having trouble creating individual review comments. Click here to see my feedback.

swift/megatron/arguments/megatron_args.py (625)

medium

Removing these version checks for mcore-bridge makes the error reporting less helpful for users with older versions of the library. Since other parts of the code (e.g., line 600) still perform version checks for mcore-bridge, it seems inconsistent to remove them here unless these features no longer have version dependencies. If the intention was to update the required version to 1.2.0 (as suggested by the documentation changes), it is better to keep the checks with the updated version string.

@Jintao-Huang Jintao-Huang merged commit 10d7127 into modelscope:main May 6, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant