update requirements#9275
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates documentation regarding mcore-bridge version requirements, extends the supported transformers version range in the framework requirements, and removes runtime version checks for mcore-bridge in the code. Feedback indicates that removing these version checks reduces the helpfulness of error reporting for users with older library versions and introduces inconsistency, suggesting that the checks should be retained with updated version strings.
I am having trouble creating individual review comments. Click here to see my feedback.
swift/megatron/arguments/megatron_args.py (625)
Removing these version checks for mcore-bridge makes the error reporting less helpful for users with older versions of the library. Since other parts of the code (e.g., line 600) still perform version checks for mcore-bridge, it seems inconsistent to remove them here unless these features no longer have version dependencies. If the intention was to update the required version to 1.2.0 (as suggested by the documentation changes), it is better to keep the checks with the updated version string.
No description provided.