Skip to content

[Bug fix] Adapt SwiftMixin.create_optimizer signature for transformers >= 4.40#9281

Merged
Jintao-Huang merged 1 commit into
modelscope:mainfrom
ys2025-AI:main
May 7, 2026
Merged

[Bug fix] Adapt SwiftMixin.create_optimizer signature for transformers >= 4.40#9281
Jintao-Huang merged 1 commit into
modelscope:mainfrom
ys2025-AI:main

Conversation

@ys2025-AI
Copy link
Copy Markdown
Contributor

PR type

  • [√] Bug Fix
  • New Feature
  • Document Updates
  • More Models or Datasets Support

PR information

Fixes #9280

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the create_optimizer method in swift/trainers/mixin.py to include an optional model parameter. There are no review comments, and I have no feedback to provide.

@Jintao-Huang Jintao-Huang merged commit 7e7545b into modelscope:main May 7, 2026
1 of 3 checks passed
@Jintao-Huang
Copy link
Copy Markdown
Collaborator

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SwiftMixin.create_optimizer() takes 1 positional argument but 2 were given with transformers >= 4.40

2 participants