[model] support gemma-4-12B-it#9487
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for the google/gemma-4-12B and google/gemma-4-12B-it models. The changes include updating the documentation for supported models in both English and Chinese, and registering the new models in the gemma model configuration file. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds support for the gemma-4-12B and gemma-4-12B-it models under a new gemma4_unified model type and architecture, updating the transformers dependency limit to <5.11.0. It also improves robust attribute retrieval for trainer methods in swift/hub/hub.py. Feedback on the changes highlights that when is_gemma4_unified is active, get_block_sequence_ids_for_mask should be imported from the unified modeling module rather than the standard gemma4 module to avoid import errors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
huggingface/transformers#46385
modelscope/mcore-bridge#108