Skip to content

[model] support gemma-4-12B-it#9487

Merged
Jintao-Huang merged 8 commits into
modelscope:mainfrom
Jintao-Huang:support_gemma4_12b
Jun 4, 2026
Merged

[model] support gemma-4-12B-it#9487
Jintao-Huang merged 8 commits into
modelscope:mainfrom
Jintao-Huang:support_gemma4_12b

Conversation

@Jintao-Huang
Copy link
Copy Markdown
Collaborator

@Jintao-Huang Jintao-Huang commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the google/gemma-4-12B and google/gemma-4-12B-it models. The changes include updating the documentation for supported models in both English and Chinese, and registering the new models in the gemma model configuration file. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Jintao-Huang
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the gemma-4-12B and gemma-4-12B-it models under a new gemma4_unified model type and architecture, updating the transformers dependency limit to <5.11.0. It also improves robust attribute retrieval for trainer methods in swift/hub/hub.py. Feedback on the changes highlights that when is_gemma4_unified is active, get_block_sequence_ids_for_mask should be imported from the unified modeling module rather than the standard gemma4 module to avoid import errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread swift/model/models/gemma.py
@Jintao-Huang Jintao-Huang merged commit 8486dbe into modelscope:main Jun 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants