Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the usability and flexibility of the API's search functionality by making the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances the search API by allowing the paths parameter to be either a single string or a list of strings, increasing its flexibility. The implementation includes updating the request model, adding a path normalization function, and improving logging. The documentation in README.md and README_zh.md has been updated accordingly to reflect these API changes. The changes are well-executed. I have one suggestion to improve the conciseness of the path normalization logic.
| cleaned: List[str] = [] | ||
| for p in paths: | ||
| if not isinstance(p, str): | ||
| continue | ||
| s = p.strip() | ||
| if s: | ||
| cleaned.append(s) |
There was a problem hiding this comment.
For improved readability and conciseness, you can use a list comprehension to filter and clean the paths. This is a more Pythonic way to achieve the same result.
| cleaned: List[str] = [] | |
| for p in paths: | |
| if not isinstance(p, str): | |
| continue | |
| s = p.strip() | |
| if s: | |
| cleaned.append(s) | |
| cleaned = [s for p in paths if isinstance(p, str) and (s := p.strip())] |
1 participant
pathsparameter: The/api/v1/searchand/api/v1/search/streamendpoints now accept thepathsparameter as either a single string or an array of strings. This provides more flexibility for specifying search directories or files.pathsparameter with fallback logic: Thepathsparameter is now optional. If omitted,null, an empty string, an empty list, or a list containing only blank strings, the server will fall back to using theSIRCHMUNK_SEARCH_PATHSenvironment variable. If that is also unset, it defaults to the server process's current working directory. Explicit non-empty paths in the request take precedence.README.mdandREADME_zh.mdfiles have been extensively updated to reflect the newpathsparameter behavior, including detailed rules, new cURL examples, and modifications to Python and JavaScript client examples to correctly handle API responses.keyword_levelsparameter has been replaced withmax_loopsin the API documentation, indicating a change in the underlying search mechanism for DEEP mode._normalize_api_paths, was introduced to consistently process and resolve thepathsparameter received from API requests, ensuring proper fallback logic.