Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Qwen3.5 series of large language models into the system, expanding the range of supported models. The changes involve updating model identifiers in various scripts and configuration files, alongside specific code adjustments in the Megatron model bridge to properly handle the architecture of Qwen3.5 models. The documentation has also been revised to reflect these new additions and provide up-to-date examples. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the cookbook, documentation, and source code to use qwen3.5 models, replacing qwen3. The changes are largely consistent with this goal. I've identified a few areas for improvement, mainly around maintaining consistency in configuration files and documentation. There is also a change in default behavior in one of the scripts that should be made more explicit. Overall, the changes are good, but addressing these points will improve the quality and clarity of the codebase.
cookbook/client/tinker/custom_service/megatron/server_config.yaml
Outdated
Show resolved
Hide resolved
cookbook/client/tinker/custom_service/megatron/server_config.yaml
Outdated
Show resolved
Hide resolved
cookbook/client/tinker/custom_service/transformer/server_config.yaml
Outdated
Show resolved
Hide resolved
cookbook/client/tinker/custom_service/transformer/server_config.yaml
Outdated
Show resolved
Hide resolved
(cherry picked from commit c5ae409)
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).