Skip to content

ops: add runtime health checks to doctor.sh #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benvinegar merged 4 commits into from
Feb 18, 2026
Merged

ops: add runtime health checks to doctor.sh #55

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
946a9d2
ops: add runtime health checks to doctor.sh
benvinegar Feb 18, 2026
c86f764
ops: fix AGENT_HOME → BAUDBOT_HOME, rename ORPHANS → WORKTREE_COUNT
benvinegar Feb 18, 2026
1385192
ops: remove worktree count and log size filler checks
benvinegar Feb 18, 2026
aaf882e
ops: warn when stale socket check is skipped without fuser
benvinegar Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions bin/doctor.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,52 @@ else
fi
fi

# ── Runtime Health ────────────────────────────────────────────────────────────

echo ""
echo "Runtime health:"

# Slack bridge
if curl -s -o /dev/null -w '%{http_code}' -X POST http://127.0.0.1:7890/send -H 'Content-Type: application/json' -d '{}' 2>/dev/null | grep -q "400"; then
pass "slack bridge responding (port 7890)"
else
warn "slack bridge not responding on port 7890"
fi

# Disk usage
DISK_PCT=$(df / 2>/dev/null | tail -1 | awk '{print $5}' | tr -d '%')
Copy link
Copy Markdown

@sentry sentry Bot Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The disk usage check uses df / which can fail on systems with long filesystem names (e.g., LVM), causing the doctor.sh script to crash.
Severity: MEDIUM

Suggested Fix

Modify the command to use the POSIX-compliant output format for df by adding the -P flag. This prevents line wrapping and ensures consistent output. The command should be df -P /.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: bin/doctor.sh#L248

Potential issue: The `doctor.sh` script parses disk usage with `df / | tail -1 | awk
'{print $5}'`. On systems with long filesystem names, such as those using LVM or network
mounts, the output of `df` wraps to a new line. This causes the parsing logic to
incorrectly assign the mount point (e.g., `/`) to the `DISK_PCT` variable. Because the
script runs with `set -e`, the subsequent attempt to perform a numeric comparison `[
"$DISK_PCT" -ge 90 ]` on a non-numeric value will cause the script to exit with an
error, preventing the health check from completing.

if [ -n "$DISK_PCT" ]; then
if [ "$DISK_PCT" -ge 90 ]; then
fail "disk usage at ${DISK_PCT}% (critical)"
elif [ "$DISK_PCT" -ge 80 ]; then
warn "disk usage at ${DISK_PCT}%"
else
pass "disk usage at ${DISK_PCT}%"
fi
fi

# Stale session sockets
SOCKET_DIR="$BAUDBOT_HOME/.pi/session-control"
if [ -d "$SOCKET_DIR" ]; then
STALE_SOCKS=0
if command -v fuser &>/dev/null; then
for sock in "$SOCKET_DIR"/*.sock; do
[ -e "$sock" ] || continue
if ! fuser "$sock" &>/dev/null 2>&1; then
STALE_SOCKS=$((STALE_SOCKS + 1))
fi
done
if [ "$STALE_SOCKS" -gt 0 ]; then
warn "$STALE_SOCKS stale session socket(s) in $SOCKET_DIR"
else
pass "no stale session sockets"
fi
else
warn "fuser not installed; skipping stale socket check"
fi
fi


# ── Summary ──────────────────────────────────────────────────────────────────

echo ""
Expand Down