chore(ci): pin actions and add pinact verification + dependabot#221
chore(ci): pin actions and add pinact verification + dependabot#221benvinegar merged 9 commits intomodem-dev:mainfrom
Conversation
Greptile SummaryThis PR hardens CI supply-chain security by pinning every third-party GitHub Action to a full commit SHA (preserving current major versions), adding a
Confidence Score: 4/5Safe to merge — purely a CI hardening change with no production code modifications. All workflow job logic is unchanged; only action references are updated to pinned SHAs. The new pinact.yml and dependabot.yml are correct and use valid configuration options. The one thing worth a second look is that pinact.yml uses actions/checkout@v6.0.2 while every other workflow was pinned to v4.3.1, which Dependabot may handle as two separate update tracks going forward. .github/workflows/pinact.yml — uses a different major version of actions/checkout than all other workflows in the repo. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR touches .github/workflows/**] --> B{pinact.yml triggers}
B --> C[actions/checkout v6.0.2]
C --> D[suzuki-shunsuke/pinact-action\nverify=true, skip_push=true]
D --> E{All actions pinned\nto SHAs?}
E -- Yes --> F[✅ Check passes]
E -- No --> G[❌ Check fails]
H[Weekly Dependabot schedule] --> I{Open PR limit reached?\nopen-pull-requests-limit: 1}
I -- No --> J[Open grouped update PR\nfor github-actions ecosystem]
I -- Yes --> K[Skip until existing PR merged]
J --> L[cooldown: 7 days\nbefore proposing update]
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
.github/workflows/pinact.yml:24-27
The new `pinact.yml` workflow uses `actions/checkout@v6.0.2` while all other workflows in this PR were pinned to `v4.3.1`. This means Dependabot will see two separate major versions across the repo and could generate split update PRs or cause confusion when reviewing SHA-pinned diffs. Consider aligning to v4.3.1 (or explicitly upgrading all workflows to v6) so the version is consistent.
```suggestion
- name: Check out repository
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
with:
persist-credentials: false
```
Reviews (1): Last reviewed commit: "chore(ci): enable Dependabot for github-..." | Re-trigger Greptile |
|
Thanks @ppluuums-jp! |
Overview
pinact run(preserves current major versions;actions/checkoutis intentionally bumped to v6)..github/workflows/pinact.ymlto verify pinning on PRs that touch workflow or composite-action files..github/dependabot.ymlfor thegithub-actionsecosystem with monthly schedule, 14-day cooldown, and grouped updates.