matlab_tool_v4.0#1
Merged
modenaxe merged 4 commits intomodenaxe:masterfrom Feb 13, 2020
Merged
Conversation
Owner
|
@KSongGitHub I have started working on the repository, soon I will review also your pool request. Thank you for your contribution! |
modenaxe
approved these changes
Feb 13, 2020
Owner
modenaxe
left a comment
modenaxe
left a comment
There was a problem hiding this comment.
I am reviewing:
- getCurrentMusclePathAsMat.m : good changes. Now getting info from the muscle path requires the state, so I agree on using getCurrentPath
- isBodyInModel: maybe there is a way of patching the function using PhysicalFrames but for now it's ok.
- getMatStructColumn: identical.
- isMuscleConnectedToBody: identical
- sto2Mat: identical
- isKinMatchingModelCoords.m : identical
I want to test the other larger functions after setting up the automated testing.
Very nice contribution, thank you Ke!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Luca, please review the v4.0 matlab code I edited based on those you shared. The uploaded PDF file documented the edits more specifically. All of my contributions are in the matlab_tool_v4.0 directory; other directories and files, including the original matlab_tool, are untouched. Thank you, and let me know if you have any questions. Ke