test: harden retriable predicate tests#23
Merged
Conversation
Folds the two deferred Minor findings from the final review: - _make_dbapi_error now asserts err.orig is not None, making the load-bearing invariant explicit. - Adds a complementary cycle case whose loop contains a retriable DBAPIError node (returns True) — companion to the terminate-on-cycle test that returns False. just test → 25 passed, 100% coverage. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #22 (squash-merged): folds the two deferred Minor findings from that PR's final whole-branch review into the in-memory predicate suite. Test-only — no production code or capability-contract change, so no
architecture/promotion.Changes (
tests/test_retriable.py)_make_dbapi_errornow assertserr.orig is not None. The whole matrix hinges on.origbeing set (the predicate reads.orig.__cause__); the assertion makes that load-bearing invariant explicit instead of relying on the True-expected cases to fail if it ever regressed.test_is_retriable_cycle_containing_retriable_link— complements the existing terminate-on-cycle test: a cyclic chain that contains a retriableDBAPIErrorlink returnsTrue(the walk finds the link before the cycle guard re-visits a node).Planning
Lightweight-lane bundle:
planning/changes/2026-06-26.02-retriable-test-hardening/change.md.Verification
just test(Docker Postgres) → 25 passed, 100% coveragejust lint-ci→ clean;just check-planning→planning: OK🤖 Generated with Claude Code