Switch to at-least-once delivery via score-based lease#5
Merged
Conversation
Replace the lock + ZREM-before-consume design with a Lua-based lease pattern: claim.lua atomically pushes the timer's score forward by lease_ttl and returns the payload; commit.lua removes the timer only after the handler ack/reject lands. This eliminates data loss on worker crash and removes the lock primitive entirely (4 RTTs -> 2). Default ack policy flipped to NACK_ON_ERROR so handler exceptions trigger retry via lease expiry. lock_ttl renamed to lease_ttl; lock_prefix removed. Handlers must now be idempotent. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the lock + ZREM-before-consume design with a Lua-based lease pattern: claim.lua atomically pushes the timer's score forward by lease_ttl and returns the payload; commit.lua removes the timer only after the handler ack/reject lands. This eliminates data loss on worker crash and removes the lock primitive entirely (4 RTTs -> 2). Default ack policy flipped to NACK_ON_ERROR so handler exceptions trigger retry via lease expiry. lock_ttl renamed to lease_ttl; lock_prefix removed. Handlers must now be idempotent.