feat(story-1.2): core data types — Request, Response, Limits, Timeout, ClientConfig#1
Merged
Merged
Conversation
…, ClientConfig Frozen, slotted dataclasses providing the immutable primitives every later module builds on. `Request` ships four `with_*` mutators backed by `dataclasses.replace`; `Response` exposes `content: bytes` plus computed `text` (charset-aware, case-insensitive header lookup) and `json()` accessors; `ClientConfig` holds the minimal config bag (base_url, default_headers/query, timeout, limits) — `transport`, `decoder`, `middleware`, `auth`, `redactor` land in later stories. All 8 ACs satisfied. 24 tests, 100% coverage on the new modules. `just lint-ci` clean. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frozen, slotted dataclasses providing the immutable primitives every later module builds on.
Requestships fourwith_*mutators backed bydataclasses.replace;Responseexposescontent: bytesplus computedtext(charset-aware, case-insensitive header lookup) andjson()accessors;ClientConfigholds the minimal config bag (base_url, default_headers/query, timeout, limits) —transport,decoder,middleware,auth,redactorland in later stories.All 8 ACs satisfied. 24 tests, 100% coverage on the new modules.
just lint-ciclean.