Particle ID incorrectly incremented

[jjstarn-usgs]

"Particle ID" can be either generated by MODPATH or specified by the user to maintain particle identities. It is not subject to zero based correction by adding 1. In modpath 7 and flopy 3.3.2, 1 is incorrectly added to the user specified particle IDs. This breaks any link the user has with specific particles. I'm not where it happens, but for a similar variable, tracerparticleid, one is added on line 643 of mp7sim.py. I searched for +1 + 1 +=1 += 1 and didn't find it.

[jdhughes-dev]

@jjstarn-usgs seems like a perfect thing for you to address. Otherwise could you provide a minimal test case that can be used to fix the bug and added to the CI?

[jjstarn-usgs]

The codes changed so much I looked at it last. I 'll take a stab at it and see if I can figure it out. Jon Jeffrey Starn Ph.D. Research hydrologist USGS New England Water Science Center 101 Pitkin Street East Hartford, CT 06108

…

________________________________ From: jdhughes-usgs <notifications@github.com> Sent: Wednesday, February 17, 2021 6:12 PM To: modflowpy/flopy <flopy@noreply.github.com> Cc: Starn, Jeffrey <jjstarn@usgs.gov>; Mention <mention@noreply.github.com> Subject: [EXTERNAL] Re: [modflowpy/flopy] Particle ID incorrectly incremented (#1053) This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding. @jjstarn-usgs<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjjstarn-usgs&data=04%7C01%7Cjjstarn%40usgs.gov%7Cf5acca9c2edf49a4417508d8d39997e0%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637492003920762705%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=EV8WT6lkHDlXcLBaudLGzixxZgmq6i50PF2kkYGTwYk%3D&reserved=0> seems like a perfect thing for you to address. Otherwise could you provide a minimal test case that can be used to fix the bug and added to the CI? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmodflowpy%2Fflopy%2Fissues%2F1053%23issuecomment-780915577&data=04%7C01%7Cjjstarn%40usgs.gov%7Cf5acca9c2edf49a4417508d8d39997e0%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637492003920772660%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=jWGB%2BIw92qrCwY9sUHStQKuJ4Y0yf6YOuS69ll4xSZo%3D&reserved=0>, or unsubscribe<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABSFX4JCZM3UJJKEI6SMFP3S7REO5ANCNFSM4XNMZUZQ&data=04%7C01%7Cjjstarn%40usgs.gov%7Cf5acca9c2edf49a4417508d8d39997e0%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637492003920772660%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=EbmiFfFeeFgSvmvM7OW52vdXx2pD572fTeaAqYcb2lQ%3D&reserved=0>.