Multiple issues with TAS files

[briochh]

I am experiencing multiple issues with models that have TIMEARRAYSERIES (TAS) packages attached to them.

1. When loading a model with a TAS file it seems that array entries after the first time repeated in the tas.tas_array object. It seems like the actual data are stored somewhere, as I think the correct files are written again on sim.write_simulation() -- just not possible to interrogate (or modify within flopy)
2. when setting sim.set_all_data_external() array data in the TAS files are ignored and they remain internal (potentially as they are not the right structure.type in the Block.set.. method?)

Any input on whether this is user error or if there are workarounds? I can't share my current example (big, ugly and sensitive) but if there is a small working example with TAS somewhere I can take a look at recreating.

[briochh]

further info:
the data stored (or accessed) on tas_array.get_active_key_list() looks like the correct data. But this is not passed through to tas_array.array. Guess this is why the correct data is written at sim.write time but it is tricky to access and interact with...

[wpbonelli]

thanks for reporting @briochh, can you confirm the fix works for you?

[briochh]

Looking good @wpbonelli, great work. One minor one on the file name increments, I think we could get away with just integer indexes right -- the float time part is stored in the parent .tas, and storage in the filename might be a little dangerous. Also there is a +1 gremlin finding its way into the file naming...

BEGIN time       0.00000000
  OPEN/CLOSE  'gwf.rcha.tas_tas_array_1.0.txt'  FACTOR  1.0
END time       0.00000000

BEGIN time      30.41670000
  OPEN/CLOSE  'gwf.rcha.tas_tas_array_31.4167.txt'  FACTOR  1.0
END time      30.41670000

• float index appended to filename
• 1 added to float index in filename

Other than that, seems to be working nicely! Thanks!

[wpbonelli]

Good points! I agree integer indexed filenames are better