Skip to content

Conversation

@spaulins-usgs
Copy link
Contributor

Minimum number of data columns was not being calculated correctly for columns that can either repeat and be zero. Replaced old calculation of minimum data columns with updated calculation based on the code that builds the column headers.

I have updated this since the last PR to solve to problems on the MF side where it was failing for flow + transport simulations. I have also added a flow + transport simulation to the t505_test autotest cases.

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #1067 (40845da) into develop (8a2cffb) will increase coverage by 0.013%.
The diff coverage is 84.745%.

@@              Coverage Diff              @@
##           develop     #1067       +/-   ##
=============================================
+ Coverage   71.761%   71.775%   +0.013%     
=============================================
  Files          225       225               
  Lines        51891     51916       +25     
=============================================
+ Hits         37238     37263       +25     
  Misses       14653     14653               
Impacted Files Coverage Δ
flopy/mf6/modflow/mfgnc.py 32.142% <ø> (ø)
flopy/mf6/modflow/mfgwf.py 55.555% <ø> (ø)
flopy/mf6/modflow/mfgwfbuy.py 58.064% <ø> (ø)
flopy/mf6/modflow/mfgwfchd.py 56.521% <ø> (ø)
flopy/mf6/modflow/mfgwfcsub.py 53.781% <ø> (ø)
flopy/mf6/modflow/mfgwfdis.py 62.222% <ø> (ø)
flopy/mf6/modflow/mfgwfdisu.py 59.154% <ø> (ø)
flopy/mf6/modflow/mfgwfdisv.py 59.574% <ø> (ø)
flopy/mf6/modflow/mfgwfdrn.py 56.000% <ø> (ø)
flopy/mf6/modflow/mfgwfevt.py 55.769% <ø> (ø)
... and 62 more

@christianlangevin christianlangevin merged commit 179fc4e into modflowpy:develop Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants