Skip to content

Conversation

@cnicol-gwlogic
Copy link
Contributor

No description provided.

_check_storage errors out on mfusg model loading due to layer:row:col indexing of flat
unstructured arrays

* modify array indexing for unstructured storage checks
* minor fixes and refatoring of test t016.py
… write fixes

flopy fails to load RCH/EVT packages from mfusg unstructured models

* add unstructured capability to modflow/mfrch and modflow/mfevt
* move rch/evt input data util2d shape detection code to utils.utils_def.get_pak_vals_shape
* add mfusg load and write tests to t016 (and t038) with different rch,evt options

resolves #896 and #633
@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #1148 (231604f) into develop (345e0fb) will increase coverage by 1.182%.
The diff coverage is 87.755%.

❗ Current head 231604f differs from pull request most recent head 5e6d4a4. Consider uploading reports for the commit 5e6d4a4 to get more accurate results

@@              Coverage Diff              @@
##           develop     #1148       +/-   ##
=============================================
+ Coverage   72.093%   73.276%   +1.182%     
=============================================
  Files          225       223        -2     
  Lines        52002     51576      -426     
=============================================
+ Hits         37490     37793      +303     
+ Misses       14512     13783      -729     
Impacted Files Coverage Δ
flopy/modflow/mfdisu.py 82.215% <50.000%> (+0.451%) ⬆️
flopy/utils/binarygrid_util.py 50.000% <50.000%> (ø)
flopy/discretization/grid.py 74.038% <71.428%> (-0.340%) ⬇️
flopy/discretization/unstructuredgrid.py 76.149% <79.069%> (+5.657%) ⬆️
flopy/utils/utils_def.py 79.710% <80.000%> (+0.080%) ⬆️
flopy/mf6/utils/binarygrid_util.py 86.335% <86.335%> (ø)
flopy/discretization/vertexgrid.py 79.775% <92.592%> (+2.691%) ⬆️
flopy/modflow/mfrch.py 95.433% <94.736%> (-0.089%) ⬇️
flopy/modflow/mfevt.py 94.146% <95.000%> (+0.092%) ⬆️
flopy/discretization/structuredgrid.py 88.485% <95.918%> (+1.018%) ⬆️
... and 26 more

Copy link

@christianlangevin christianlangevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @cnicol-gwlogic. Thanks for putting this all together.

@christianlangevin christianlangevin merged commit b780bfb into modflowpy:develop Jul 13, 2021
@cnicol-gwlogic cnicol-gwlogic deleted the fix_rchu_evtu branch July 22, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants