-
Notifications
You must be signed in to change notification settings - Fork 349
feat(mf6-lake): add helper function to create lake connections #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jdhughes-dev
merged 15 commits into
modflowpy:develop
from
jdhughes-dev:feat-lake-connections
Aug 5, 2021
Merged
feat(mf6-lake): add helper function to create lake connections #1163
jdhughes-dev
merged 15 commits into
modflowpy:develop
from
jdhughes-dev:feat-lake-connections
Aug 5, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1163 +/- ##
=============================================
- Coverage 72.215% 0.000% -72.216%
=============================================
Files 228 229 +1
Lines 52734 51527 -1207
=============================================
- Hits 38082 0 -38082
- Misses 14652 51527 +36875
|
christianlangevin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff.
…files (modflowpy#1162) * feat(get_reduced_pumping): update to read external pumping reduction files * updated ListBudget.get_reduced_pumping() to call new method * moved static IO code to flopy_io.py * PEP8 cleanups in mflistfile.py * update(MfListBudget, CsvFile): updates to read pumping reduction from AG pkg * linting
…ion or model relative path changed (modflowpy#1126) (modflowpy#1157) * refact(paths): New simulation and model method "set_all_data_internal" added that sets all data internal. This method is automatically called whenever the simulation or model path are changed. This greatly simplifies flopy's behavior since flopy no longer needs to keep track of former and new external file paths that can possibly change multiple times before write is called. * refact(path): Added combination of changing model relative path and setting all data external to test case. * fix(cleanup): code cleanup * fix(code cleanup): code cleanup * fix(set data internal/external): code made more general to handle transient data without stress period keys * fix(formatting) * feat(data columns + paths): Flopy now automatically defaults to ncol for max_columns_of_data. Added support for specifying where to store external files when calling set_all_files_external. Path is relative to model(s)/simulation. Added several more path tests.
…y into feat-lake-connections # Conflicts: # autotest/t078_lake_connections.py # flopy/mf6/utils/lakpak_utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.