Skip to content

Conversation

@jdhughes-dev
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #1163 (6bd78a3) into develop (c98a476) will decrease coverage by 72.215%.
The diff coverage is 0.000%.

❗ Current head 6bd78a3 differs from pull request most recent head 0a46fee. Consider uploading reports for the commit 0a46fee to get more accurate results

@@              Coverage Diff              @@
##           develop    #1163        +/-   ##
=============================================
- Coverage   72.215%   0.000%   -72.216%     
=============================================
  Files          228      229         +1     
  Lines        52734    51527      -1207     
=============================================
- Hits         38082        0     -38082     
- Misses       14652    51527     +36875     
Impacted Files Coverage Δ
flopy/datbase.py 0.000% <ø> (-76.471%) ⬇️
flopy/discretization/vertexgrid.py 0.000% <ø> (-79.776%) ⬇️
flopy/export/netcdf.py 0.000% <0.000%> (-54.243%) ⬇️
flopy/export/shapefile_utils.py 0.000% <ø> (-87.983%) ⬇️
flopy/export/utils.py 0.000% <0.000%> (-68.855%) ⬇️
flopy/export/vtk.py 0.000% <0.000%> (-88.860%) ⬇️
flopy/mbase.py 0.000% <0.000%> (-70.703%) ⬇️
flopy/mf6/coordinates/modeldimensions.py 0.000% <ø> (-83.069%) ⬇️
flopy/mf6/data/mfdata.py 0.000% <ø> (-76.080%) ⬇️
flopy/mf6/data/mfdataarray.py 0.000% <0.000%> (-65.982%) ⬇️
... and 308 more

Copy link

@christianlangevin christianlangevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.

jdhughes-dev and others added 12 commits July 28, 2021 17:19
…files (modflowpy#1162)

* feat(get_reduced_pumping): update to read external pumping reduction files

* updated ListBudget.get_reduced_pumping() to call new method
* moved static IO code to flopy_io.py
* PEP8 cleanups in mflistfile.py

* update(MfListBudget, CsvFile): updates to read pumping reduction from AG pkg

* linting
…ion or model relative path changed (modflowpy#1126) (modflowpy#1157)

* refact(paths): New simulation and model method "set_all_data_internal" added that sets all data internal.  This method is automatically called whenever the simulation or model path are changed.  This greatly simplifies flopy's behavior since flopy no longer needs to keep track of former and new external file paths that can possibly change multiple times before write is called.

* refact(path): Added combination of changing model relative path and setting all data external to test case.

* fix(cleanup): code cleanup

* fix(code cleanup): code cleanup

* fix(set data internal/external): code made more general to handle transient data without stress period keys

* fix(formatting)

* feat(data columns + paths): Flopy now automatically defaults to ncol for max_columns_of_data. Added support for specifying where to store external files when calling set_all_files_external.  Path is relative to model(s)/simulation.  Added several more path tests.
…y into feat-lake-connections

# Conflicts:
#	autotest/t078_lake_connections.py
#	flopy/mf6/utils/lakpak_utils.py
@jdhughes-dev jdhughes-dev merged commit 73a4405 into modflowpy:develop Aug 5, 2021
@jdhughes-dev jdhughes-dev deleted the feat-lake-connections branch August 5, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants