Skip to content

fix(check): check now works properly with confined conditions (#1880) #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2023
Merged

fix(check): check now works properly with confined conditions (#1880) #1882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d0d095
fix(check): check now works properly with confined conditions (#1880)
scottrp Jul 26, 2023
8ec09c7
github workflows undo
scottrp Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion autotest/regression/test_mf6.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,9 +948,14 @@ def test_np002(function_tmpdir, example_data_path):
oc_package.printrecord.set_data([("HEAD", "ALL"), ("BUDGET", "ALL")], 1)

sto_package = ModflowGwfsto(
model, save_flows=True, iconvert=1, ss=0.000001, sy=0.15
model, save_flows=True, iconvert=0, ss=0.000001, sy=None, pname="sto_t"
)
sto_package.check()

model.remove_package("sto_t")
sto_package = ModflowGwfsto(
model, save_flows=True, iconvert=1, ss=0.000001, sy=0.15
)
hfb_package = ModflowGwfhfb(
model,
print_input=True,
Expand Down
9 changes: 9 additions & 0 deletions flopy/pakbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,15 @@ def _check_storage(self, chk, storage_coeff):
skip_sy_check = True
else:
iconvert = self.iconvert.array
inds = np.array(
[
True if l > 0 or l < 0 else False
for l in iconvert.flatten()
]
)
if not inds.any():
skip_sy_check = True

for ishape in np.ndindex(active.shape):
if active[ishape]:
active[ishape] = (
Expand Down