fix(GridIntersect): combine list of geometries using unary_union #1923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1923 +/- ##
=======================================
Coverage 72.6% 72.6%
=======================================
Files 257 257
Lines 57603 57604 +1
=======================================
+ Hits 41831 41838 +7
+ Misses 15772 15766 -6
|
dbrakenhoff
approved these changes
Aug 21, 2023
Contributor
dbrakenhoff
left a comment
dbrakenhoff
left a comment
There was a problem hiding this comment.
Looks good! I have a test that reproduces the bug in #1922 and passes with this change. I don't think I can add to this PR, so I'll submit a separate PR?
christianlangevin
approved these changes
Aug 21, 2023
|
It's merged, @dbrakenhoff, so go ahead and submit another PR with the test. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix uses
shapely.unary_union(orshapely.ops.unary_union) to combine a list of 1 or more [Multi]LineString geometries into one geometry.Ideas on a test for this would be welcome.
Closes #1922