Skip to content

Conversation

@mjr-deltares
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.5%. Comparing base (7eb7c88) to head (ff5624e).
Report is 24 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2514      +/-   ##
===========================================
- Coverage     76.1%    55.5%   -20.7%     
===========================================
  Files          296      644     +348     
  Lines        64215   124157   +59942     
===========================================
+ Hits         48885    68922   +20037     
- Misses       15330    55235   +39905     
Files with missing lines Coverage Δ
flopy/mf6/utils/model_splitter.py 74.9% <100.0%> (-0.2%) ⬇️

... and 484 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlarsen-usgs jlarsen-usgs self-requested a review May 16, 2025 15:57
@mjr-deltares
Copy link
Contributor Author

Hi @jlarsen-usgs , thanks for looking at this. The point is that the origins can be taken from the base model in case of DISV and DISU. Let me know if anything is unclear.

Copy link
Contributor

@jlarsen-usgs jlarsen-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjr-deltares the changes look good to me

@mjr-deltares mjr-deltares merged commit cc32103 into modflowpy:develop May 21, 2025
20 checks passed
@mjr-deltares mjr-deltares deleted the splitter_offsets branch May 21, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants