Merged
Conversation
fix bug where open/close fails on one cell in a SPD and support pathlib.Path in MFlist. New tests added. No breaking change
fix bug where open/close fails on one cell in a SPD and support pathlib.Path in MFlist. New tests added. No breaking change
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2638 +/- ##
===========================================
+ Coverage 55.5% 72.6% +17.0%
===========================================
Files 644 667 +23
Lines 124135 129132 +4997
===========================================
+ Hits 68947 93770 +24823
+ Misses 55188 35362 -19826
🚀 New features to boost your workflow:
|
mwtoews
reviewed
Oct 17, 2025
Contributor
mwtoews
left a comment
There was a problem hiding this comment.
Howdy Matt, I've provided a few suggestions.
Co-authored-by: Mike Taves <mwtoews@gmail.com>
Co-authored-by: Mike Taves <mwtoews@gmail.com>
fix bug where open/close fails on one cell in a SPD and support pathlib.Path in MFlist. New tests added. No breaking change
Contributor
Author
|
@mwtoews sorted |
wpbonelli
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 2 bugs regarding MFList when reading external files.
First, allow the use of pathlib.Path objects rather than just strings
Second, fix a bug where calculating mxact raises an error when reading a stress period file with only one feature.
Created two new tests to support these features and ran all automated tests. The only failures were:
From the traceback I belive that these failures are based on my configuration and setup not the changes (note that many of these are not related to Modflow2005/nwt