Skip to content

Fix open/close bugs#2638

Merged
wpbonelli merged 5 commits intomodflowpy:developfrom
hansonmcoombs:develop
Oct 17, 2025
Merged

Fix open/close bugs#2638
wpbonelli merged 5 commits intomodflowpy:developfrom
hansonmcoombs:develop

Conversation

@hansonmcoombs
Copy link
Copy Markdown
Contributor

Fix 2 bugs regarding MFList when reading external files.

First, allow the use of pathlib.Path objects rather than just strings

Second, fix a bug where calculating mxact raises an error when reading a stress period file with only one feature.

Created two new tests to support these features and ran all automated tests. The only failures were:

  • autotest.test_mbase.test_resolve_exe_by_abs_path
  • autotest.test_mbase.test_resolve_exe_by_name
  • autotest.test_example_notebooks.test_notebooks
  • autotest.regression.test_mf6.test006_2models_different_dis
  • autotest.regression.test_mf6.test006_create_tests_2models_gnc

From the traceback I belive that these failures are based on my configuration and setup not the changes (note that many of these are not related to Modflow2005/nwt

fix bug where open/close fails on one cell in a SPD and support pathlib.Path in MFlist. New tests added.

No breaking change
fix bug where open/close fails on one cell in a SPD and support pathlib.Path in MFlist. New tests added.

No breaking change
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.6%. Comparing base (556c088) to head (09b61fb).
⚠️ Report is 79 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2638      +/-   ##
===========================================
+ Coverage     55.5%    72.6%   +17.0%     
===========================================
  Files          644      667      +23     
  Lines       124135   129132    +4997     
===========================================
+ Hits         68947    93770   +24823     
+ Misses       55188    35362   -19826     
Files with missing lines Coverage Δ
flopy/utils/util_list.py 73.6% <100.0%> (-2.1%) ⬇️

... and 559 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@mwtoews mwtoews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy Matt, I've provided a few suggestions.

Comment thread flopy/utils/util_list.py Outdated
Comment thread flopy/utils/util_list.py Outdated
Comment thread autotest/test_util_2d_and_3d.py Outdated
Comment thread autotest/test_util_2d_and_3d.py Outdated
hansonmcoombs and others added 3 commits October 17, 2025 14:37
Co-authored-by: Mike Taves <mwtoews@gmail.com>
Co-authored-by: Mike Taves <mwtoews@gmail.com>
fix bug where open/close fails on one cell in a SPD and support pathlib.Path in MFlist. New tests added.

No breaking change
@hansonmcoombs
Copy link
Copy Markdown
Contributor Author

@mwtoews sorted

@wpbonelli wpbonelli merged commit d5cc962 into modflowpy:develop Oct 17, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants