fix(MfUsgWel): add get_empty() override to support WELLBOT parameter#2656
Merged
wpbonelli merged 3 commits intomodflowpy:developfrom Dec 2, 2025
Merged
Conversation
- Fixes TypeError when loading MFUSG models with WELLBOT option - Adds static method get_empty() that accepts wellbot parameter - WELLBOT option was already parsed in pakbase.py but not handled in dtype creation - Enables loading of USG-Transport models with well bottom elevations Resolves issue where models using 'WELLBOT' option in WEL package would fail with: TypeError: ModflowWel.get_empty() got an unexpected keyword argument 'wellbot'
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2656 +/- ##
===========================================
+ Coverage 55.5% 72.6% +17.1%
===========================================
Files 644 667 +23
Lines 124135 129356 +5221
===========================================
+ Hits 68947 93994 +25047
+ Misses 55188 35362 -19826
🚀 New features to boost your workflow:
|
wpbonelli
approved these changes
Dec 2, 2025
Member
wpbonelli
left a comment
There was a problem hiding this comment.
makes sense to have for wel since we have it on other usg packages, thanks @reneangermeyer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue where models using 'WELLBOT' option in WEL package would fail with: TypeError: ModflowWel.get_empty() got an unexpected keyword argument 'wellbot'