Skip to content

fix(MfUsgWel): add get_empty() override to support WELLBOT parameter#2656

Merged
wpbonelli merged 3 commits intomodflowpy:developfrom
reneangermeyer:fix/mfusg-wellbot-support
Dec 2, 2025
Merged

fix(MfUsgWel): add get_empty() override to support WELLBOT parameter#2656
wpbonelli merged 3 commits intomodflowpy:developfrom
reneangermeyer:fix/mfusg-wellbot-support

Conversation

@reneangermeyer
Copy link
Copy Markdown
Contributor

  • Fixes TypeError when loading MFUSG models with WELLBOT option
  • Adds static method get_empty() that accepts wellbot parameter
  • WELLBOT option was already parsed in pakbase.py but not handled in dtype creation
  • Enables loading of USG-Transport models with well bottom elevations

Resolves issue where models using 'WELLBOT' option in WEL package would fail with: TypeError: ModflowWel.get_empty() got an unexpected keyword argument 'wellbot'

- Fixes TypeError when loading MFUSG models with WELLBOT option
- Adds static method get_empty() that accepts wellbot parameter
- WELLBOT option was already parsed in pakbase.py but not handled in dtype creation
- Enables loading of USG-Transport models with well bottom elevations

Resolves issue where models using 'WELLBOT' option in WEL package would fail
with: TypeError: ModflowWel.get_empty() got an unexpected keyword argument 'wellbot'
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.6%. Comparing base (556c088) to head (9ef5670).
⚠️ Report is 88 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/mfusg/mfusgwel.py 91.6% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2656      +/-   ##
===========================================
+ Coverage     55.5%    72.6%   +17.1%     
===========================================
  Files          644      667      +23     
  Lines       124135   129356    +5221     
===========================================
+ Hits         68947    93994   +25047     
+ Misses       55188    35362   -19826     
Files with missing lines Coverage Δ
flopy/mfusg/mfusgwel.py 93.3% <91.6%> (+1.4%) ⬆️

... and 559 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to have for wel since we have it on other usg packages, thanks @reneangermeyer

@wpbonelli wpbonelli merged commit 5a94526 into modflowpy:develop Dec 2, 2025
19 of 20 checks passed
@reneangermeyer reneangermeyer deleted the fix/mfusg-wellbot-support branch December 2, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants