Skip to content

fix(get_transmissivities): support DISU#2685

Merged
wpbonelli merged 1 commit intomodflowpy:developfrom
wpbonelli:fix-2170
Jan 24, 2026
Merged

fix(get_transmissivities): support DISU#2685
wpbonelli merged 1 commit intomodflowpy:developfrom
wpbonelli:fix-2170

Conversation

@wpbonelli
Copy link
Copy Markdown
Member

@wpbonelli wpbonelli commented Jan 24, 2026

Follow up on #2611 to support DISU. Closes #2170.

Plus forward-looking refactoring in case we add more grid types before 4.x comes out. Rather than conditionals everywhere to access/modify grid properties differently based on the grid type, add an adapter exposing what's needed consistently. This is necessary because grid properties may have different shapes depending on the grid type. In 4.x this can be avoided by design I think. But for now this makes the essence of the transmissivities calculation clearer.

@wpbonelli wpbonelli added this to the 3.10 milestone Jan 24, 2026
@wpbonelli wpbonelli added bug refactor Non-functional changes labels Jan 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 87.09677% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.3%. Comparing base (556c088) to head (7158dc3).
⚠️ Report is 111 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/postprocessing.py 87.0% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2685      +/-   ##
===========================================
+ Coverage     55.5%    72.3%   +16.8%     
===========================================
  Files          644      667      +23     
  Lines       124135   130284    +6149     
===========================================
+ Hits         68947    94275   +25328     
+ Misses       55188    36009   -19179     
Files with missing lines Coverage Δ
flopy/utils/postprocessing.py 80.0% <87.0%> (+2.4%) ⬆️

... and 562 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli marked this pull request as ready for review January 24, 2026 21:01
@wpbonelli wpbonelli merged commit 978d7d0 into modflowpy:develop Jan 24, 2026
19 checks passed
@wpbonelli wpbonelli deleted the fix-2170 branch January 24, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug refactor Non-functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: get_transmissivities() does not work with MODFLOW 6 models

1 participant