Skip to content

fix(HeadUFile): disable get_alldata without layer#2686

Merged
wpbonelli merged 1 commit intomodflowpy:developfrom
wpbonelli:fix-1502
Jan 30, 2026
Merged

fix(HeadUFile): disable get_alldata without layer#2686
wpbonelli merged 1 commit intomodflowpy:developfrom
wpbonelli:fix-1502

Conversation

@wpbonelli
Copy link
Copy Markdown
Member

Close #1502. The issue is that get_alldata() assumes regular structure that USG files don't have. We could return e.g. a list of arrays or some other ragged representation but I figure better to acknowledge the limitation clearly than to return something technically valid but confusing. So, block usage of the method without providing a layer.

@wpbonelli wpbonelli added the bug label Jan 24, 2026
@wpbonelli wpbonelli added this to the 3.10 milestone Jan 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.3%. Comparing base (556c088) to head (21c5698).
⚠️ Report is 121 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/binaryfile/__init__.py 75.0% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2686      +/-   ##
===========================================
+ Coverage     55.5%    72.3%   +16.8%     
===========================================
  Files          644      667      +23     
  Lines       124135   130292    +6157     
===========================================
+ Hits         68947    94280   +25333     
+ Misses       55188    36012   -19176     
Files with missing lines Coverage Δ
flopy/utils/binaryfile/__init__.py 82.3% <75.0%> (-2.2%) ⬇️

... and 562 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli marked this pull request as ready for review January 24, 2026 21:38
@wpbonelli wpbonelli merged commit 6bb9c1a into modflowpy:develop Jan 30, 2026
20 checks passed
@wpbonelli wpbonelli deleted the fix-1502 branch January 30, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: warning when calling get_alldata() of class HeadUFile for Unstructured MODFLOW-USG HeadUFile

2 participants