Skip to content

fix(rasters): fix raster_from_array transformation order#2689

Merged
wpbonelli merged 1 commit intomodflowpy:developfrom
wpbonelli:fix-2553
Jan 28, 2026
Merged

fix(rasters): fix raster_from_array transformation order#2689
wpbonelli merged 1 commit intomodflowpy:developfrom
wpbonelli:fix-2553

Conversation

@wpbonelli
Copy link
Copy Markdown
Member

@wpbonelli wpbonelli commented Jan 25, 2026

Reorder the transform to accommodate opposite y axis conventions. This matches the order in export/utils.py::export_array(). Close #2553

@wpbonelli wpbonelli added the bug label Jan 25, 2026
@wpbonelli wpbonelli added this to the 3.10 milestone Jan 25, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.3%. Comparing base (556c088) to head (8f7c1c7).
⚠️ Report is 113 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2689      +/-   ##
===========================================
+ Coverage     55.5%    72.3%   +16.8%     
===========================================
  Files          644      667      +23     
  Lines       124135   130284    +6149     
===========================================
+ Hits         68947    94276   +25329     
+ Misses       55188    36008   -19180     
Files with missing lines Coverage Δ
flopy/utils/rasters.py 71.1% <100.0%> (-2.9%) ⬇️

... and 562 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli marked this pull request as ready for review January 25, 2026 20:16
@jlarsen-usgs jlarsen-usgs self-requested a review January 28, 2026 15:34
@wpbonelli wpbonelli merged commit 61e9e31 into modflowpy:develop Jan 28, 2026
20 checks passed
@wpbonelli wpbonelli deleted the fix-2553 branch January 28, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: raster_from_array() on a rotated modelgrid produces a raster with rotation in the opposite direction of modelgrid

2 participants